Sunlighting from custom presets is not applied on multiplayer clients

abbradar

See title. This is actually a Lua code bug. The following patch fixes that for the Conquest mode (similar changes need to be done for other gamemodes):

diff -ru3 "a/Info/Lua/Gamemodes/conquest/clientside.lua" "b/Info/Lua/Gamemodes/conquest/clientside.lua"
--- "a/Info/Lua/Gamemodes/conquest/clientside.lua"	2017-08-17 19:36:46.998852936 +0300
+++ "b/Info/Lua/Gamemodes/conquest/clientside.lua"	2017-08-23 01:32:51.086067000 +0300
@@ -75,7 +75,11 @@
 			end
 		end
 	end
-  
+
+	if (sv_Settings.sunElevationMin ~= nil) then
+		Skybox.Sun.SunElevationLimits = Vector2.New(sv_Settings.sunElevationMin, sv_Settings.sunElevationMax)
+	end
+
 	DisplayDisclaimer()
 end
 Hooks.Connect(hk_OnNewLevelReady, OnNewLevelReady)

We have tested that the fix works but obviously as I'm not familiar with the code I might have done something wrong.

DrWhoCares

Good find, I hope this gets fixed soon!

Shatojon

Thank you, I'll forward this to QA.

abbradar

@Shatojon A test case for this bug is described at http://forums.castlestory.net/discussion/comment/2985/#Comment_2985 (may be useful too!)